ip_address only accepts unicode on Python 2 #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipaddress.ip_address('127.0.0.1') fails with ValueError on Python 2
need to decode it, otherwise 127.0.0.1 won't be treated as local
so this list isn't empty when these handlers are used outside NotebookApp
minrk
commented
Jul 31, 2018
| try: | ||
| addr = ipaddress.ip_address(host) | ||
| except ValueError: | ||
| # Not an IP address: check against hostnames | ||
| allow = host in self.settings.get('local_hostnames', []) | ||
| allow = host in self.settings.get('local_hostnames', ['localhost']) |
There was a problem hiding this comment.
additionally, added 'localhost' as the default here so that it is defined by default when used outside NotebookApp, e.g. nbdime.
|
Thanks! |
This was referenced Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipaddress.ip_address('127.0.0.1') fails with ValueError on Python 2
need to decode it, otherwise 127.0.0.1 won't be treated as local
workaround in the meantime should be to use 'localhost' instead of '127.0.0.1'
closes jupyter/nbdime#408
cc @vidartf