Add japanese translation files #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
commented
Mar 19, 2019
crazymaster
reviewed
Mar 26, 2019
crazymaster
suggested changes
Mar 26, 2019
|
Thanks a lot! |
takluyver
reviewed
Apr 28, 2019
notebook/i18n/nbjs.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "domain": "nbjs", | |||
| "supported_languages": [ | |||
| "fr-FR", | |||
| "ja_JP", | |||
There was a problem hiding this comment.
What browser are you using? This list should probably be consistent in using - or _, and if different browsers do different things, we may need to work around that.
There was a problem hiding this comment.
Google Chrome.
The name of UNIX locale on japanese/japan is ja_JP. But the browser send ja.
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Co-Authored-By: mattn <mattn.jp@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser send Accept-Language
janotja_JP.