Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily import requests_unixsocket #5649

Closed
wants to merge 1 commit into from
Closed

Lazily import requests_unixsocket #5649

wants to merge 1 commit into from

Conversation

blink1073
Copy link
Contributor

Fixes #5644

@blink1073
Copy link
Contributor Author

cc @kevin-bates. I'm happy to cut the release with this patch.

@blink1073 blink1073 mentioned this pull request Aug 3, 2020
Closed
@blink1073
Copy link
Contributor Author

Ha, I think we need a combination of this and #5650

@kevin-bates
Copy link
Member

Looks like we just duplicated some efforts. 😄

Thanks for looking at this. I guess I addressed this slightly differently in that I also prevent the inclusion of the requests_unixsocket package, although I like the idea of deferring its import as you did.

@blink1073
Copy link
Contributor Author

Sounds like a plan. Closing in favor of #5650

@blink1073 blink1073 closed this Aug 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing using notebook>=6.1 requires requests_unixsocket
2 participants
@blink1073 @kevin-bates