Allow jupyter_server-based contents managers in notebook #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Jan 21, 2021
Co-authored-by: Kevin Bates <kbates4@gmail.com>
kevin-bates
approved these changes
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notebook's
contents_manager_classtrait doesn't accept subclasses of jupyter_server'sContentsManager. This is a problem for anyone looking to write custom, forward-looking contents managers. We should relax this constraint here (albeit, raise a warning).This PR relaxes the
contents_manager_classto allow these managers. To do this, newtraittypesare defined and used that check the incoming types/instances against a list of classes.