-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show_banner trait to control the banner display #6808
Merged
RRosio
merged 3 commits into
jupyter:6.5.x
from
datalayer-externals:feat/show_banner_trait
Mar 31, 2023
Merged
Add show_banner trait to control the banner display #6808
RRosio
merged 3 commits into
jupyter:6.5.x
from
datalayer-externals:feat/show_banner_trait
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
Mar 31, 2023
echarles
changed the title
A a show_banner trait to control the banner display
Add show_banner trait to control the banner display
Mar 31, 2023
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
ericsnekbytes
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved.
RRosio
reviewed
Mar 31, 2023
Co-authored-by: Rosio <rosio_reyes@yahoo.com>
Thank you @echarles, this looks great! I can merge if no one else is planning to? |
Thx all for reviews and enhancements @RRosio Yes, please merge if it works for you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6798
Use
--NotebookApp.show_banner=False
to disable the banner display.