Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_banner trait to control the banner display #6808

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

echarles
Copy link
Member

Fixes #6798

Use --NotebookApp.show_banner=False to disable the banner display.

@echarles echarles changed the base branch from main to 6.5.x March 31, 2023 07:10
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch datalayer-externals/jupyter-notebook/feat/show_banner_trait

@jtpio jtpio added this to the 6.5 milestone Mar 31, 2023
@echarles echarles changed the title A a show_banner trait to control the banner display Add show_banner trait to control the banner display Mar 31, 2023
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Copy link
Collaborator

@ericsnekbytes ericsnekbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved.

notebook/notebookapp.py Outdated Show resolved Hide resolved
Co-authored-by: Rosio <rosio_reyes@yahoo.com>
@RRosio
Copy link
Collaborator

RRosio commented Mar 31, 2023

Thank you @echarles, this looks great! I can merge if no one else is planning to?

@echarles
Copy link
Member Author

Thx all for reviews and enhancements

@RRosio Yes, please merge if it works for you

@RRosio RRosio merged commit 428e00b into jupyter:6.5.x Mar 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add an option to disable the Notebook 7 migration banner administratively
4 participants