Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename browser tab title to Home #6913

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Rename browser tab title to Home #6913

merged 2 commits into from
Jun 12, 2023

Conversation

Cheukting
Copy link
Contributor

When showing tree the title is Home in the classic notebook UI. This fix makes it consistent.

closes #6912

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Binder 👈 Launch a Binder on branch Cheukting/notebook/rename-home

@Cheukting
Copy link
Contributor Author

It fails because the test is expecting "- Tree</title>" - will check and fix

@Cheukting
Copy link
Contributor Author

Cheukting commented Jun 10, 2023

The last test that is failing is the triage label. I don't know if it is something that I have to do on my end. Otherwise, it is ready for review. Thank you in advance.

@jtpio jtpio added this to the 7.0 milestone Jun 12, 2023
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio changed the title Rename browser tab title to Home (#6912) Rename browser tab title to Home Jun 12, 2023
@jtpio jtpio merged commit f276c54 into jupyter:main Jun 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename browser tab title to Home
2 participants