Make jupyter logo select properly (#6927) #6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for working on this @Cheukting. |
|
@andrii-i do you know what might be causing the ui tests to fail? |
|
Here's a video of a failing test attempt extracted from the failed run report page: video.webm |
|
The Firefox UI tests are a bit flaky. |
tonyfast
reviewed
Jun 20, 2023
andrii-i
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Logo now selects properly, thank you for working on this @Cheukting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
margin: autoandz-index: 10to make the Jupyter logo tab selected properly.closes #6927