Update ruff config #7190
Merged
Update ruff config #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! The UI tests failure might be relevant? Unless it is caused by a new release of an underlying package? actual (extra home icon)
expected
|
|
I addressed that failure, but it looks like there is a pre-existing race condition, because this firefox test failed with the same error as this chromium test did: https://github.com/jupyter/notebook/actions/runs/7198343749/job/19607743050 |
|
Thanks! Is this the same error? Now the issue seems to be related to the trusted indicator not being displayed correctly: Actual
Expected
But this is likely not related to this PR, as it also happens in #7191 now. |
|
Ah, okay, seems like a race condition. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use updated recommendations for Ruff config, and the new ruff
docstring-code-formatthat replacesblacken-docs.