Redirect paths from the notebooks route to the tree route if they are directories #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andyscho
force-pushed
the
notebooks-route-directory-redirect-to-tree
branch
from
22aa6d8 to
3820e3e
Compare
|
Nice, thanks @andyscho for looking into this! |
jtpio
approved these changes
Sep 9, 2024
|
|
||
| NotebookHandler.redirect = redirect | ||
| await jp_fetch("notebooks", "jlab_test_notebooks") | ||
| assert redirected_url == "/a%40b/tree/jlab_test_notebooks" |
There was a problem hiding this comment.
Thanks for adding this test!
In addition to this test, maybe it could be interesting to add a UI test to mimic real user interactions: https://github.com/jupyter/notebook/tree/main/ui-tests
But we can track that in a separate issue 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7445 by checking if
notebooks/<path>paths are directories before attempting to load them as notebooks.