Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JupyterCAD to 3.0.0a6 #8

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Nov 19, 2024

Should address jupytercad/JupyterCAD#582

@martinRenou
Copy link
Member

The CI will fail, #7 will fix it

@arjxn-py
Copy link
Member Author

Preparing metadata (pyproject.toml): finished with status 'error' I wonder what's wrong exactly?

@martinRenou
Copy link
Member

The actual error message is somewhere else (it's always annoying to find the actual error message with hatch):

src/index.ts(4,8): error TS2307: Cannot find module '@jupyter/docprovider' or its corresponding type declarations

Seems to be a missing dependency on docprovider

@arjxn-py
Copy link
Member Author

I see, I'm on it. Thanks

@arjxn-py
Copy link
Member Author

Failed again on Parsed an error from text content: undefined Plugin 'jupytercad_openvsp:plugin' failed to activate. Maybe

id: 'jupytercad_openvsp:plugin',

@martinRenou
Copy link
Member

When a plugin fails to activate, there is usually another error prior to that in the JavaScript console that tells you what caused the failure. Have you tried locally?

@arjxn-py
Copy link
Member Author

arjxn-py commented Nov 19, 2024

When a plugin fails to activate, there is usually another error prior to that in the JavaScript console that tells you what caused the failure. Have you tried locally?

Yeah, just did. It says:

image

EDIT- i reuploaded the image with more logs

@trungleduc
Copy link
Member

you need to update the shared packages in package.json, like in this commit jupytercad/JupyterCAD-FreeCAD@7e390ad#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

@arjxn-py
Copy link
Member Author

you need to update the shared packages in package.json

Thanks @trungleduc, done in 2b77531

@arjxn-py
Copy link
Member Author

Tested locally too, it's working fine.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 2f254f6 into jupytercad:main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants