Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform controls: undo positioning upon failure #610

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

martinRenou
Copy link
Member

Fix #588

Screencast.From.2024-11-29.09-18-09.mp4

@martinRenou martinRenou added the bug PR that fixes a bug label Nov 29, 2024
@martinRenou martinRenou changed the title Dry run failure Transform controls: undo positioning upon failure Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

Integration tests report: appsharing.space

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Preview PR at appsharing.space

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou 🚀

@trungleduc trungleduc merged commit 8485813 into jupytercad:main Nov 29, 2024
10 checks passed
@martinRenou martinRenou deleted the dry_run_failure branch November 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After dry-run failure, we should bring back the MeshGroup's original position
3 participants