Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing file versioning #623

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Introducing file versioning #623

merged 10 commits into from
Dec 2, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou added the enhancement New Feature or improvement label Dec 2, 2024
@martinRenou
Copy link
Member Author

martinRenou commented Dec 2, 2024 •
edited
Loading

We would need to improve error handling jupyter-collaboration's side, as it's hiding the actual error we are raising:

Screenshot From 2024-12-02 12-35-09

The raised error shows up in the server logs only:

ValueError: Cannot load file version 4.0.0

@martinRenou martinRenou marked this pull request as ready for review December 2, 2024 11:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Preview PR at appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Integration tests report: appsharing.space

@martinRenou martinRenou marked this pull request as draft December 2, 2024 12:38
@martinRenou martinRenou marked this pull request as ready for review December 2, 2024 14:15
@martinRenou
Copy link
Member Author

WAT .src/stlplugin/model.ts(2,3): error TS2305: Module '"@jupytercad/schema"' has no exported member 'SCHEMA_VERSION'

@martinRenou
Copy link
Member Author

ah got it, the typing from index.ts was not exported

@martinRenou martinRenou merged commit f37ac37 into jupytercad:main Dec 2, 2024
10 checks passed
@martinRenou martinRenou deleted the schemaVersoin branch December 2, 2024 14:48
@martinRenou martinRenou mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc