use loose semver parsing to accept more prerelease formats

[minrk]

accepts standards like 1.2.3b4 as seen in Python, etc.

seems like the shortest path to jupyterhub/jupyterhub#3612

[consideRatio]

Can you add a test case to the existing tests, verifying that 2.0.0b1 should return ["2.0.0b1"] rather than for example ["2", "2.0", "2.0.0", "2.0.0b1"] ?

Nice find with the loose parameter! This looks great to me if it works as intended!

[consideRatio]

For reference, this is where I read about loose: https://github.com/npm/node-semver#functions

[consideRatio]

❤️ @manics having written tests

[manics]

I agree a test would be good. Should be easy to add, just copy and paste one of the existing cases e.g.

action-major-minor-tag-calculator/__tests__/main.test.js

Lines 207 to 215 in 0cfbca0

	test("Unsupported prerelease tag", async () => {
	const tags = await calculateTags({
	token: "TOKEN",
	owner: "owner",
	repo: "repo",
	ref: "refs/tags/2.0.0-rc1",
	});
	expect(tags).toEqual(["2.0.0-rc1"]);
	});

or

action-major-minor-tag-calculator/__tests__/main.test.js

Lines 183 to 205 in 0cfbca0

	test("Handling build number comparisons numerically", async () => {
	const scope = nock("https://api.github.com")
	.get("/repos/owner/repo/tags")
	.reply(200, [
	{
	name: "1.0.0",
	},
	{
	name: "2.0.0-2",
	},
	{
	name: "1.1.0-2",
	},
	]);
	const tags = await calculateTags({
	token: "TOKEN",
	owner: "owner",
	repo: "repo",
	ref: "refs/tags/1.1.0-10",
	});
	expect(tags).toEqual(["1.1.0-10", "1.1.0", "1.1", "1"]);
	scope.done();
	});

Assuming it all works, shall we release as 2.0.0 since this is a change in behaviour? Does anyone have any other issues or annoyances involving a breaking change that they want to get into 2.0.0?

[minrk]

I only saw 'test.js', which I guess was leftover from an older clone, and not even in the repo! I missed __tests__. Test added (and it works now, thanks to the test!)

[consideRatio]

LGTM! Thanks @minrk!