Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bumping dev deps and group production PRs #317

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 1, 2023

Let's get this merged before November 1!

@manics
Copy link
Member

manics commented Oct 4, 2023

Sounds like a good idea! Is there a reason we need to exclude dev dependencies- couldn't we just update everything in one go?

@consideRatio
Copy link
Member Author

I see some value in separating prod from dev dependencies, but if we are to bump both - maybe I'd prefer one less PR by combing them.

My preferences ordered, but happy to go based on yours:

  1. prod only bumped
  2. prod and dev bumped
  3. prod and dev bumped, grouped by prod and dev separetely, so two PRs are opened monthly for this

Do you prefer to go with option 2, bumping dev deps also in the same PR @manics?

@manics
Copy link
Member

manics commented Oct 4, 2023

Yes, I was thinking of bumping prod+dev (and anything else!) in one PR. Unless there's a good reason not to bump dev dependencies?

@consideRatio
Copy link
Member Author

Unless there's a good reason not to bump dev dependencies?

Not really, but I figured there wasn't a strong case for bumping them either. With that I vaguely reasoned that we could opt to not be bothered doing it monthly to avoid clutter the PRs we are to review with non-important changes to review.


I pushed a commit that I think gets it done!

@consideRatio consideRatio force-pushed the pr/grop-bump-prs-and-stop-bumping-dev branch from abd3dec to 717632f Compare October 4, 2023 23:35
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manics manics merged commit aa716eb into jupyterhub:main Oct 5, 2023
1 check passed
@consideRatio
Copy link
Member Author

Thank you @manics!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to redefine package.json in a way to reduce dependacy bumps?
2 participants