Update all dependencies, move to Node 20 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the all-dependencies group with 5 updates: | Package | From | To | | --- | --- | --- | | [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github) | `5.1.1` | `6.0.0` | | [@vercel/ncc](https://github.com/vercel/ncc) | `0.38.0` | `0.38.1` | | [eslint](https://github.com/eslint/eslint) | `8.50.0` | `8.52.0` | | [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `27.4.2` | `27.6.0` | | [nock](https://github.com/nock/nock) | `13.3.3` | `13.3.7` | Updates `@actions/github` from 5.1.1 to 6.0.0 - [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github) Updates `@vercel/ncc` from 0.38.0 to 0.38.1 - [Release notes](https://github.com/vercel/ncc/releases) - [Commits](vercel/ncc@0.38.0...0.38.1) Updates `eslint` from 8.50.0 to 8.52.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.50.0...v8.52.0) Updates `eslint-plugin-jest` from 27.4.2 to 27.6.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v27.4.2...v27.6.0) Updates `nock` from 13.3.3 to 13.3.7 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v13.3.3...v13.3.7) --- updated-dependencies: - dependency-name: "@actions/github" dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-dependencies - dependency-name: "@vercel/ncc" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-dependencies - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: eslint-plugin-jest dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
|
Ignore the pre-commit status, we don't use pre-commit in this repo since it's all handled by npm |
consideRatio
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Thank you @manics!! Looks good to me, so we go for a major version release with this merged i figure.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322 which bump the version of @actions/github to 6.0.0, requiring node 20.
It looks like
@actions/githubuses fetch to make http calls which can't be mocked by Nock nock/nock#2183 so I've switch to usingundici.MockAgentwhich seems to be the default implementation for fetch in Node.This will hopefully get rid of the
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/warning that appears on invocations of the last release of this action.