Allow prefix to be a whitespace/comma separated list of prefixes #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
commented
Nov 23, 2023
This project enables pushing the same image to multiple tags, and with this feature it can enable pushing the same image to multiple destinations with multiple tags. A use case for this is if we want to push to both Docker Hub and Quay.io for example, then prefix could be `"user/repo,quay.io/user/repo"`.
consideRatio
force-pushed
the
pr/allow-prefix-to-have-multiple-values
branch
from
9906027
to
975bd35
Compare
|
Wiee!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project enables pushing the same image to multiple tags, and with this feature it can enable pushing the same image to multiple destinations with multiple tags.
A use case for this is if we want to push to both Docker Hub and Quay.io for example, then prefix could be
"user/repo,quay.io/user/repo".I'd like us to not drop docker hub entirely and instead push to quay.io alongside dockerhub if its easy enough, and this makes it easy enough I think. I imagine it makes this small change possible in jupyterhub/configurable-http-proxy's publish workflow for example.
- name: Setup push rights to Docker Hub if: startsWith(github.ref, 'refs/tags/') run: | docker login -u "${{ secrets.QUAY_USERNAME }}" -p "${{ secrets.QUAY_PASSWORD }}" quay.io + docker login -u "${{ secrets.DOCKERHUB_USERNAME }}" -p "${{ secrets.DOCKERHUB_PASSWORD }}" docker.io - name: Get list of tags id: gettags uses: jupyterhub/action-major-minor-tag-calculator@v2 with: githubToken: ${{ secrets.GITHUB_TOKEN }} - prefix: "quay.io/jupyterhub/configurable-http-proxy:" + prefix: "quay.io/jupyterhub/configurable-http-proxy: jupyterhub/configurable-http-proxy:" defaultTag: quay.io/jupyterhub/configurable-http-proxy:noref - name: Build and push uses: docker/build-push-action@v5 with: platforms: linux/amd64,linux/arm64 push: ${{ startsWith(github.ref, 'refs/tags/') }} # tags parameter must be a string input so convert `gettags` JSON # array into a comma separated list of tags tags: ${{ join(fromJson(steps.gettags.outputs.tags)) }}