Skip to content

Commit

Permalink
Remove timeout from pytest.mark.asyncio
Browse files Browse the repository at this point in the history
`ERROR binderhub/tests/test_build.py - ValueError: mark.asyncio accepts only a keyword argument 'scope'.`
  • Loading branch information
manics authored Nov 7, 2024
1 parent d36f86a commit 9962914
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions binderhub/tests/test_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

# We have optimized this slow test, for more information, see the README of
# https://github.com/binderhub-ci-repos/minimal-dockerfile.
@pytest.mark.asyncio(timeout=900)
@pytest.mark.asyncio
@pytest.mark.parametrize(
"slug",
[
Expand Down Expand Up @@ -102,7 +102,7 @@ async def test_build(app, needs_build, needs_launch, always_build, slug, pytestc
stop.raise_for_status()


@pytest.mark.asyncio(timeout=900)
@pytest.mark.asyncio
@pytest.mark.parametrize(
"app,build_only_query_param",
[
Expand Down Expand Up @@ -152,7 +152,7 @@ async def test_build_only(app, build_only_query_param, needs_build):
assert final["phase"] == "ready"


@pytest.mark.asyncio(timeout=120)
@pytest.mark.asyncio
@pytest.mark.remote
async def test_build_fail(app, needs_build, needs_launch, always_build):
"""
Expand All @@ -176,7 +176,7 @@ async def test_build_fail(app, needs_build, needs_launch, always_build):
assert failed_events > 0, "Should have seen phase 'failed'"


@pytest.mark.asyncio(timeout=120)
@pytest.mark.asyncio
@pytest.mark.parametrize(
"app,build_only_query_param,expected_error_msg",
[
Expand Down Expand Up @@ -485,7 +485,7 @@ async def test_local_repo2docker_build():
assert docker_client.images.get(name)


@pytest.mark.asyncio(timeout=20)
@pytest.mark.asyncio
async def test_local_repo2docker_build_stop(io_loop):
q = Queue()
# We need a slow build here so that we can interrupt it, so pick a large repo that
Expand Down

0 comments on commit 9962914

Please sign in to comment.