-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter Server support #1634
Comments
I think this is the reason why https://mybinder.org/v2/gh/jupyter/docker-stacks/main?urlpath=lab/tree/README.ipynb is broken for |
I hope it will be fixed after a merge :) |
It doesn't work for me :( |
@mathbunnyru It's fixed in BinderHub, but it's not yet deployed to mybinder.org |
Thank you @manics. I thought it was deployed automatically after GitHub push. Could you please ping me when it will be deployed? |
@mathbunnyru Since it's a potentially disruptive breaking change it'll be announced on Discourse. |
@mathbunnyru this has been deployed to mybinder.org now |
@minrk, thank you. I've updated the image and confirm it works well 👍 |
It seems to be a bit slow to start, though. (after building image) |
Proposed change
Recent JupyterLab, and a growing number of extensions require the newer Jupyter Server, and will no longer run on the legacy
jupyter-notebook
server. But BinderHub (without auth) hardcodes the launch command asjupyter-notebook
, and there's no way for repos to opt-in to the current standard Jupyter server (except by redefiningjupyter-notebook
).At this point, I think we should switch to launching jupyter-server by default, which I think will be more compatible more often, but is a backward-incompatible change for some repos, especially those that may have old server extensions. In a binder context, I think there are far more lab extensions than classic nb extensions, so I think at this point it will result in fewer broken repos, not more. But it's still a breaking change since which repos are broken will change.
xref jupyter-server/jupyter_server#1038
Alternative options
Make this an option somehow, and possibly opt-in (eventually, it has to be opt-out since we're currently defaulting to a deprecated package that already doesn't work with the current version of our default UI). I don't know where to express that., though, in a way that's going to work.
Who would use this feature?
Everyone who wants to use recent JupyterLab or any other Jupyter frontends other than
notebook<7
.(Optional): Suggest a solution
Add to our launch command
jupyter-server
by default with a fallback onjupyter-notebook
. We could gate this on the presence of Jupyter Server 2.0, because Jupyter Server 1.0 tends to be compatible with the legacy notebook server. This decision isn't really made by the user though, it's made for most repos by the repo2docker base env. And I think it would be pretty weird to say 'if you want to launch the old jupyter-notebook, install jupyter-server<2.'The text was updated successfully, but these errors were encountered: