Hack to launch jupyter-server #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COPY/RUN chown doubles the size of the repo in the image also make sure NB_USER is not empty and present in system info
BinderHub forces a launch of the legacy jupyter-notebook server, but our base image has upgraded jupyterlab and jupyter-server to a version that doesn't support it the alternative would be to pin-down jupyter server and everything using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces image size by hundreds of MB by:
COPY --chowninstead of two-stepCOPY/RUN chownwhich doubles size in imageHacks a fix for too-new jupyterlab, jupyter-server and friends by replacing
jupyter-notebookwithjupyer-lab. This is really a problem BinderHub/repo2docker need to fix.