-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor index.js megafile into mutliple files #777
Comments
To be clear - this is before any reactification (reacting? reaction?) happens, right? I am so happy we are finally doing this! |
Yep. No React-ification. Just moving and refactoring things so it is easier to Reactify down the line. |
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
#1761 fixes this, following the plan @captainsafia laid out :) |
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
- Follows the plan laid out in jupyterhub#777 - Only non-trivial move is to cleanup the `_config` call to use the more modern 'fetch' API rather than the older XMLHttpRequest API Fixes jupyterhub#777
It only took about 4+ years, but this is finally done :) Thanks for the guidance, @captainsafia! |
To aid with our conversion to React and to ease front-end development on Binder (#774), we'll need to refactor the
index.js
mega file into multiple files with discrete functions. The goal here is to move all the functions into files that will roughly map to React components or library functions in the future.Steps
src
directory.index.js
.Tips
Checklist
Here's a checklist of the functions/components that need to be moved out into separate files. This list isn't complete yet but is enough to get the ball rolling.
image.js
(Move Image class to separate file #776)setUpLog
intolog.js
updateUrls
andv2url
tourl.js
getBuildFormValues
toform.js
. The function should take the jQuery form element as a parameter and extract the individual form fields from the children within.markdownBade
andrstBadge
functions into badge.js (Move badge and path functions out of megafile #778)getPathType
andupdatePathText
topath.js
. (Move badge and path functions out of megafile #778)updateRepoText
torepo.js
cc: @yuvipanda @choldgraf @betatim
The text was updated successfully, but these errors were encountered: