Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ipv6 support when checking network bans #1889

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

yuvipanda
Copy link
Collaborator

@yuvipanda yuvipanda commented Nov 27, 2024

Discovered while investigating the test failures in #1856

- Rely on using `in` between IP addresses and IP Networks
  (https://docs.python.org/3/library/ipaddress.html#networks-as-containers-of-addresses)
  rather than re-implement that ip address / network matching with
  CIDRs ourselves.
- Brings in *much* better ipv6 support
- Adds a few test cases for ipv6 support as well

Discovered while investigating the test failures in
jupyterhub#1856
@yuvipanda yuvipanda requested review from minrk and manics November 27, 2024 06:04
@minrk minrk merged commit 0dd37ea into jupyterhub:main Nov 27, 2024
13 checks passed
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot nicer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants