Don't stop when 2 tests fail #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the false impression that only two tests are failing, and is very surprising behavior to have as default. Users who want this can pass the commandline arg to `py.test` when they want it.
|
Took me entirely by surprise in #1856 |
manics
approved these changes
Dec 7, 2024
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Dec 8, 2024
jupyterhub/binderhub#1892 Merge pull request #1892 from yuvipanda/no-maxfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the false impression that only two tests are failing, and is very surprising behavior to have as default. Users who want this can pass the commandline arg to
py.testwhen they want it.