Require Python >= 3.10 (broken on older versions) #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinderHub is broken on Python 3.8:
```
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/runner/work/binderhub/binderhub/binderhub/__main__.py", line 2, in <module>
from binderhub.app import main
File "/home/runner/work/binderhub/binderhub/binderhub/app.py", line 45, in <module>
from .base import VersionHandler
File "/home/runner/work/binderhub/binderhub/binderhub/base.py", line 13, in <module>
from .utils import ip_in_networks
File "/home/runner/work/binderhub/binderhub/binderhub/utils.py", line 172, in <module>
ip_addr: str, networks: Iterable[ipaddress.IPv4Network | ipaddress.IPv6Network]
```
BinderHub is broken on Python 3.9:
```
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/runner/work/binderhub/binderhub/binderhub/__main__.py", line 2, in <module>
from binderhub.app import main
File "/home/runner/work/binderhub/binderhub/binderhub/app.py", line 45, in <module>
from .base import VersionHandler
File "/home/runner/work/binderhub/binderhub/binderhub/base.py", line 13, in <module>
from .utils import ip_in_networks
File "/home/runner/work/binderhub/binderhub/binderhub/utils.py", line 172, in <module>
ip_addr: str, networks: Iterable[ipaddress.IPv4Network | ipaddress.IPv6Network]
```
consideRatio
approved these changes
Jan 25, 2025
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jan 30, 2025
jupyterhub/binderhub#1914 Merge pull request #1914 from manics/test-oldest-python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BinderHub Python metadata claims to support Python 3.8, but this isn't tested, and the code base now contains some syntax that requires Python 3.10.
The alternative to bumping the minimum version is to ensure the code is compatible with 3.8 (or 3.9).