Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Tweak loading messages #858

Merged
merged 1 commit into from
May 31, 2019

Conversation

betatim
Copy link
Member

@betatim betatim commented May 25, 2019

Instead of always saying "30s or longer" I think it is better to have a "starting" and "taking longer than usual" message. The change here is to show the "longer than usual" message earlier. I chose the cutoff at 17s because the median launch time is around 15s. 90% of launches complete in under a minute and 99% in around 4minutes. Maybe we can use these stats to build a "progress bar" for launches.

@betatim betatim force-pushed the tweak-load-time branch from 943dc18 to 851025f Compare May 25, 2019 08:50
@betatim betatim requested a review from choldgraf May 28, 2019 05:08
@choldgraf
Copy link
Member

choldgraf commented May 28, 2019

I think this is a good idea and I like the language. What do you think about also adding a link to the Binder FAQ about "what affects the launch time" section: https://mybinder.readthedocs.io/en/latest/faq.html#what-factors-influence-how-long-it-takes-a-binder-session-to-start

Something like appending this at the end:

"Curious what affects the length of launches? Check out the Binder documentation."

Could also give something to click and read while they wait.

Feel free to say "lets iterate on that language in a different PR" if you like.

@betatim
Copy link
Member Author

betatim commented May 28, 2019

I'd advocate iterating because I think the page is already far too busy with links, unfoldable content (the build log) and potentially a preview (or a 404 because preview doesn't work), etc.

My current suggestion would be to replace the "New to Binder ..." line with a more specific one like you suggested "Curious how to make this faster? ...click here..." when the launch takes more than 20seconds or so:

Screen Shot 2019-05-28 at 18 13 54

But I'd do that in a second PR because I don't know how to do it off the top of my head :)

@consideRatio
Copy link
Member

I think also we should not have a mentioning of a specific number of seconds, but I think we could perhaps do something like kubespawners progressbar listening on events, but instead we are a bit time dependent.

One thing we could do is utilize the size of the image perhaps.

@betatim
Copy link
Member Author

betatim commented May 31, 2019

Shall we merge this and then see how we can improve? I think this PR gets us to a state that is better than what we currently have.

@consideRatio consideRatio merged commit 6dc0f0c into jupyterhub:master May 31, 2019
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request May 31, 2019
@betatim betatim deleted the tweak-load-time branch June 20, 2019 20:08
@choldgraf choldgraf added the maintenance Under the hood improvements and fixes label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants