Docker updates #104
Merged
Docker updates #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing separate alpine file
Otherwise, the API isn't accessible even when ports are forwarded without manually requesting `--api-ip` An entrypoint wrapper is used so that only the default behavior is changed, but `--api-ip` can still be passed to the command.
willingc
reviewed
Apr 19, 2017
| # Default api-ip to all interfaces in docker, | ||
| # so that it is accessible to other containers | ||
| # and when port-forwarding is requested. | ||
| ARGS="--api-ip=0.0.0.0" |
There was a problem hiding this comment.
Does the ip address need to be in quotes? ARGS="--api-ip='0.0.0.0'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that the API port is accessible via port forwarding, etc.
without having to also specify
--api-ipby hand.closes #101
closes #102