Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query string is an object, but also not an object, on node6 #83

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 30, 2016

hasOwnProperty is not defined, even though typeof q is object.

This should get tests passing on node 6

hasOwnProperty is not defined, even though `typeof q` is object.
@rgbkrk
Copy link
Member

rgbkrk commented Sep 30, 2016

Odd.

@rgbkrk rgbkrk merged commit 67e3f21 into jupyterhub:master Sep 30, 2016
minrk pushed a commit to minrk/configurable-http-proxy that referenced this pull request Oct 12, 2016
… object, on node6

hasOwnProperty is not defined, even though `typeof q` is object.

This should get tests passing on node 6
@minrk
Copy link
Member Author

minrk commented Oct 12, 2016

Turns out this was deliberate though there doesn't appear to be any public reasoning behind it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants