Publish TigerVNC and TurboVNC image to quay.io #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will automatically update this comment whenever this PR is modified
|
consideRatio
force-pushed
the
pr/turbovnc
branch
from
a8f8d51
to
3b8ebd5
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/turbovnc
branch
from
3b8ebd5
to
5fcb6bd
Compare
yuvipanda
approved these changes
Feb 15, 2024
Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>
|
The I'll go for a merge! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dockerfile so that it can build to include TigerVNC (default) or TurboVNC by passing
--build-arg vncserver=turbovnc. It then automates a build and publishing of an image in two variants:quay.io/jupyterhub/jupyter-remote-desktop-proxy:<version>(the same as-tigervnc)quay.io/jupyterhub/jupyter-remote-desktop-proxy:<version>-tigervncquay.io/jupyterhub/jupyter-remote-desktop-proxy:<version>-turbovncFixes Publish two docker images - one with TigerVNC, and one with TurboVNC? #88
Provides multi arch images, Amd64 and Arm64
Fixes Add tests to verify basic function with supported VNC servers #68
In a very primitive way though, where I think Add an integration test for VNC + websockify #93 improves on testing beyond this basic check