Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server data dir (/var/run/rstudio) not writable. Support multiple rstudio-server versions #119

Merged
merged 4 commits into from
Dec 22, 2021

Conversation

ccoulombe
Copy link
Contributor

@ccoulombe ccoulombe commented Dec 10, 2021

By default, the option --set-data-dir points to /var/run/rstudio which is not writable other then by sudo. Set the option to a temporary directory.

Support multiple rstudio-server versions, from v1.2.1335 and up

@welcome
Copy link

welcome bot commented Dec 10, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ccoulombe ccoulombe changed the title Use SLURM_TMPDIR when possible. Set server-data-dir to temporary dir Set server-data-dir to temporary dir Dec 10, 2021
@yuvipanda yuvipanda requested a review from ryanlovett December 17, 2021 10:40
@ryanlovett
Copy link
Collaborator

Thanks for this @ccoulombe ! In a similar PR, #118, I suggested it'd be better to create the data dir outside of db_config() and then pass the directory in as a parameter. I think this is more logical since the data dir is used for things other than the db. For example, something like this.

I like expanding the rserver parameters when they're supported by the help text.

@ccoulombe ccoulombe changed the title Set server-data-dir to temporary dir Fix server data dir (/var/run/rstudio) not writable. Support multiple rstudio-server versions Dec 17, 2021
@ccoulombe
Copy link
Contributor Author

ccoulombe commented Dec 17, 2021

@ryanlovett I'll update according to your comments in the PR.

@ryanlovett ryanlovett merged commit 613226b into jupyterhub:master Dec 22, 2021
@welcome
Copy link

welcome bot commented Dec 22, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@ryanlovett
Copy link
Collaborator

Thanks again @ccoulombe ! Sorry for the delay -- I had missed that you updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants