Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation for progressive proxies from #479, we only make the request progressive if the Accept Header of the request is exactly
text/event-stream
. We would like to use this feature with other proxies, where the Mime-Type is not so directly determinable, like with xpra (Remote Destop).As far as I can tell, there is no particular reason to limit the progressive feature to only this use case (see #502).
I changed the code to instead allow configuring the behavior of the proxy via the entrypoint of a proxy. The dictionary returned by the entry point can now contain a value "progressive". When set to either
True
orFalse
, we can explicitly enable or disable the progressive proxying. When left empty, we will automatically determine what type of proxy to use (see theprogressive
property).It can also be a function, when the developer wants to dynamically switch between progressive and buffered proxying.