Change use_lookup_dn_username
default value to False
#280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default change (only relevant if
lookup_dn=True
) makes JupyterHub usernames end up what was entered into the login form, as compared to end up what was looked up from a found user's value of the attribute which name was configured viause_lookup_dn_username
.In practice, this can be the difference between getting JupyterHub usernames like
philip j. fry
(normalized fromPhilips J. Fry
) andfry
when entering the usernamefry
when logging in.I propose this breaking change because:
bind_dn_template
tolookup_dn
configs less likely to change existing jupyterhub users' usernames.Overall, I'm not sure if there is a security risk or not related to this, but since I've not ruled it out I figure this is the safer default.