Add clarification note and contents detail #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Sep 19, 2017
README.md
Outdated
|
|
||
| - `common.yaml` configuration settings that are used in all deployment files | ||
| - `local.yaml` (TODO) | ||
| - `staging.yaml` config used for staging a BinderHub deployment for testing | ||
| - `staging.yaml` config used for staging the `beta.mybinder.org` deployment |
There was a problem hiding this comment.
It's the config for the 'staging' binder service, which currently lives at https://binder.binder-staging.omgwtf.in/ (and should move to staging.mybinder.org at some point)
yuvipanda
reviewed
Sep 19, 2017
README.md
Outdated
|
|
||
| ### repo root directory | ||
|
|
||
| - `common.yaml` (TODO: How does this differ from the common.yaml in the binder directory) |
There was a problem hiding this comment.
This file should just be removed.
yuvipanda
reviewed
Sep 19, 2017
| [binderhub-deploy]: https://github.com/jupyterhub/binderhub-deploy | ||
| [BinderHub]: https://github.com/jupyterhub/binderhub | ||
| [JupyterHub]: https://github.com/jupyterhub/jupyterhub | ||
| ### `support` directory |
There was a problem hiding this comment.
This contains a set of 3rd party charts we use for supporting our own code on the binder deployment. The charts we use and their versions are specified in requirements.yaml, and the configuration of those charts is in values.yaml.
There was a problem hiding this comment.
Added this content.
|
I left some comments but otherwise looks good, @willingc! Tyvm! |
|
tyvm @willingc! |
rgaiacs
added a commit
to gesiscss/mybinder.org-deploy
that referenced
this pull request
Sep 6, 2024
Add GitLab CI Kubernetes agent for stage Closes jupyterhub#3 See merge request methods-hub/interactive-environment!2
rgaiacs
added a commit
to gesiscss/mybinder.org-deploy
that referenced
this pull request
Sep 6, 2024
Add GitLab CI Closes jupyterhub#3 See merge request methods-hub/interactive-environment!3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2