Use our own jinja2 template loader #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Our template loader setup was a hack, and that hack seems to have stopped working. - We just use our own loader instead. This means we lose the base translation functionality of upstream render_template - but we were not using it at all anyway, so 'tis alright. - Looks like the path for the stylesheet we were 'borrowing' from classic notebook changed location, so update to use the new location. This will stop existing after notebook v7, and we will need to use our own. Fixes jupyterhub#235
|
@betolink you might be interested in this too. |
choldgraf
approved these changes
Mar 16, 2022
|
Can someone here make it to one our Jupyter Server Contributor Hours? 😃 It would be really fun to try and port this extension in real-time. Then, we can process record, document, and share this in the server docs. I'm happy to lead the development and we can pair program as a team during the call. |
|
Just to be clear @Zsailer - you're talking about the resolution of this issue, right? Agree that would be great :-) but I'm still +1 on merging this PR in the meantime! |
|
Ah, yes—I was referring to #240. Sorry for the confusion! 😃 |
|
Thanks a lot, @manics! Do you think we can do a release? |
|
I think so, if we don't need anything from #240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have stopped working.
translation functionality of upstream render_template - but we
were not using it at all anyway, so 'tis alright.
from classic notebook changed location, so update to use the
new location. This will stop existing after notebook v7,
and we will need to use our own.
Fixes #235