Support pipfiles

[yuvipanda]

Moving from jupyterhub/binderhub#357

I think if we have a Pipfile, we should do the following:

1. Use a virtualenv
2. Ignore requirements.txt
3. Install packages with Pipfile

[minrk]

Agreed, except we can skip "use a virtualenv" since pipenv should cover that. It should also ignore runtime.txt, since pipenv covers installing Python itself with pyenv as well.

[choldgraf]

Does it seem reasonable to wait until we can pip install -p using pipfiles? Seems like whenever that functionality is there, it would be quite easy to support installing pipfiles almost the same way you'd do with requirements.txt.

[minrk]

Does it seem reasonable to wait until we can pip install -p using pipfiles?

Yes, that would be reasonable. It depends on if we want to adopt the prototype implementation or wait for it to be solidified. One advantage of adopting the pipenv prototype is that it supports installing Python itself, which would solve the availability of Python 3.6.

[minrk]

Another advantage of pipfiles is that it could deprecate runtime.txt, since it solves the Python-version problem for requirements.txt in a standard way, rather than a separate, custom file.

[choldgraf]

Seeing as how binder is in beta anyway, I'm +1 on adding pipfile support now so long as we don't think it'll be a pain to maintain

[choldgraf]

Just taking a look to see if pipfile has matured at all, and...

...is that project under active development? Assuming this is the repo, there hasn't been anything merged into master since late September, and it doesn't seem like the dev(s?) are responding to issues/PRs...

[yuvipanda]

https://docs.pipenv.org/ is the appropriate docs + links to repo I think.

…

On Fri, Feb 9, 2018 at 3:23 PM, Chris Holdgraf ***@***.***> wrote: Just taking a look to see if pipfile has matured at all, and... ...is that project under active development? Assuming this is the repo <https://github.com/pypa/pipfile>, there hasn't been anything merged into master since late September, and it doesn't seem like the dev(s?) are responding to issues/PRs... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#174 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB23u1viiGrOGLEc4PwWjdeXTFksc9Rks5tTNOPgaJpZM4RHxMs> .

-- Yuvi Panda T http://yuvi.in/blog

[jezcope]

My understanding is that the Pipfile spec itself is now pretty stable and most of the active work is on pipenv as the reference implementation, as per @yuvipanda's link. I hadn't seen before but it looks like it's now being described as "the officially recommended Python packaging tool from Python.org".

[choldgraf]

that is great news! a lack of activity because everyone is in general agreement to the spec is much preferable to a lack of activity because the project is stale :-)

[jzf2101]

jupyterhub/binderhub#559

[choldgraf]

Is pipfile support a matter of "somebody just needs to make the PR" now? Or are we waiting for something to change in the pipfile spec etc? Just asking so we can clarify the issue w/ a path forward!

[yuvipanda]

@choldgraf yep, it's 'someone needs to make a PR'.

[trallard]

Jumping on here 👋 it seems this is looking for someone to work on the issue and create a PR so I am volunteering myself to do this
Would this be ok @betatim @choldgraf ?

[choldgraf]

woooo go go go @trallard! :-)

[Madhu94]

Is this ticket good to close ?

[betatim]

Not yet as #447 added a Pipfile to this repo but not pipfile support to repo2docker. Do you want to start working on this? Would be a cool addition!

[betatim]

@trallard do you have some (half done) code for this? After seeing https://twitter.com/palewire/status/1100786779848728576 I am keen/re-invigorated to get Pipenv support done :) Adding support for it would be a good way for me to learn what they are and how it works but if you have already done some work we should base it on that.

[trallard]

Hey sorry this fell through the cracks 😑 I have some work done for this will push it ASAP

[choldgraf]

let us know how we can help @trallard !

[consideRatio]

+1 @trallard I consider this to be of massive value to BinderHub, I'd be happy to help!

[betatim]

@consideRatio if you want to get started on this I think it would be Ok to open a PR. I think @trallard is super busy so we can move ahead without waiting.