-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis deploy tags to PyPI #89
Travis deploy tags to PyPI #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. I don't have any experience with versioneer, but I've picked up on a not to positive sentiment about it.
I hope to avoid needing to learn about versioneer also, but will do if someone suggest I do because it makes sense to use it alongside no tool or bump2version that we have also used in other jupyterhub projects.
Co-Authored-By: Erik Sundell <erik.i.sundell@gmail.com>
Ping @manics @betatim @choldgraf @willingc @minrk who have been active in discussion about this kind of tooling within jupyterhub/team-compass#213. Me and @GeorgianaElena find ourselves having no experience using versioneer and involved in the maintenance of this repo, having a file named versioneer.py. In JupyterHub repos I've only seen bump2version and custom scripts so far. This is the first JH repo with versioneer I've seen. My suggestion is that we remove it from this repo. Is that okay? I'm also fine not doing it, but it would be nice with a call on this. |
I've never used versioneer either |
https://github.com/warner/python-versioneer/blob/master/README.md |
Additional information, apparently versioneer may be unmaintained which would be a reason to remove it: |
I can't remember where but I believe that we've discussed versioneer before in another thread, and concluded that it was overkill. I'd be +1 on removing it from this repository now, and if folks want to re-consider using it across all the repositories, then we can open a team-compass issue about it |
After looking in |
I would not change the use of versioneer here; that can be a separate discussion, with pros and cons, mostly summarized as:
I'm not sure if I would object to removing versioneer if a problem does indeed arise, but releasing a versioneer project is simpler and easier than releasing one that requires manual editing of one or more files because making the tag is the always the only step and requires no installation of additional tools (e.g. bump2version). |
I updated the PR with everyone's feedback. Hope I didn't miss anything :) I will open a new issue to summarize our discussion here and keep it for future reference. |
We use versioneer in repo2docker and it works well. It is a long file but (and this is where it is better than all other things I've used) it just works. I've never needed to read the code and I don't know of a situation where To create a release the instructions are https://repo2docker.readthedocs.io/en/latest/contributing/tasks.html#creating-a-release There are three steps: |
After the commit suggestion i made is committed, I want to press merge! This looks very thorough to me! |
Co-Authored-By: Erik Sundell <erik.i.sundell@gmail.com>
Thanks @GeorgianaElena for thorough work with this PR and the patience with deliverations regarding tooling involved! ❤️ 🎉 |
This copies the release steps from other JupyterHub repos ✨
The only difference is that traefik-proxy uses versioneer that takes care of the project version and some steps are missing.
(@consideRatio I never worked with versioneer before, but from what I've read it seems that version is updated by it and we don't have to do anything. What do you think?)