Update NOTES.txt, including removing "alpha" designation #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes direct commands for extracting IPs/NodePort
manics
changed the title
consideRatio
approved these changes
Apr 28, 2021
jupyterhub/templates/NOTES.txt
Outdated
Comment on lines
51
to
53
| 3. If you find a bug please report it at https://github.com/jupyterhub/zero-to-jupyterhub-k8s/issues{{ println }} | ||
|
|
||
| {{- if hasKey .Values.singleuser.cloudMetadata "enabled" }}{{ println }} | ||
| {{- if hasKey .Values.singleuser.cloudMetadata "enabled" }} |
There was a problem hiding this comment.
Assuming someone would copy paste the deprecation logic, they would need {{ println }} in it at least assuming two deprecation messages would trigger - in order to avoid no new blank line between them.
There was a problem hiding this comment.
Whenever there is a fail it is not relevant with later messages as it would stop the rendering, but if it is a warning - multiple warnings can trigger.
Below there is a deprecation warning like this that includes println still while this doesn't any more. I suggest we consistently use println within each.
|
@manics thank you so much for maintaining, well, everything !! ❤️ |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Apr 28, 2021
jupyterhub/zero-to-jupyterhub-k8s#2165 Merge pull request #2165 from manics/update-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes direct commands for extracting IPs/NodePort (not sure if this is too complicated? though it makes it easier for people who don't immediately understand how to parse
kubectl get svc proxy-public)TODO: