fix(daemonset): Allow the definition a ServiceAccount in DaemonSets #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samyuh
changed the title
samyuh
changed the title
samyuh
changed the title
|
Hey @manics could you take a look at this? |
manics
reviewed
Aug 7, 2024
samyuh
changed the title
samyuh
commented
Aug 13, 2024
|
@manics check this again when you can, everything is working as expected |
manics
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Other than a couple of queries this looks good to me, thanks for working on this.
@consideRatio would you mind reviewing this? I'm not fully confident about all the changes.
|
@consideRatio please take a look when you can :) |
|
@manics can you push this to have the second review and be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the option to define a ServiceAccount in DaemonSets used in the prepuller.
Closes #3442