Handle the 'NoSchedule' taint on nodes properly #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is usually used to prevent pods from scheduling on a node without explicit tolerations. The defaults for many cluster management setups (such as https://github.com/Azure/acs-engine and I think many amazon setups) use this to prevent master from being scheduled, so we should respect this.
|
I'm pretty sure we need this for 0.6 |
willingc
approved these changes
Jan 29, 2018
| } | ||
| } | ||
|
|
||
| return !node.Spec.Unschedulable |
There was a problem hiding this comment.
Gotta love the double negatives.
yuvipanda
added a commit
to yuvipanda/datahub-old-fork
that referenced
this pull request
Jan 30, 2018
Should bring in version of prepuller with jupyterhub/zero-to-jupyterhub-k8s#458 fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is usually used to prevent pods from scheduling on a node
without explicit tolerations. The defaults for many cluster management
setups (such as https://github.com/Azure/acs-engine and I think
many amazon setups) use this to prevent master from being scheduled,
so we should respect this.
Fixes #454