update local install instructions for minikube #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! There was a merge conflict introduced with #554 and this one, so I assumed this took precedence since it had more complete information. |
|
Shouldn't this be in the |
|
hmm, did it not make it into master in the end? I think it was eventually merged into master here: #551 |
|
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/CONTRIBUTING.md is missing the changes from this PR |
willingc
added a commit
that referenced
this pull request
Mar 6, 2018
Merge in changes missed in #554
|
Ah yes! Good catch! I think this just got merged a second ago
…On Tue, Mar 6, 2018, 3:33 PM Simon Li ***@***.***> wrote:
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/CONTRIBUTING.md
is missing the changes from this PR
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABwSHQ2X8pfOUxCOteia9mVEynnZY62Rks5tbp4cgaJpZM4SaCB7>
.
|
|
@choldgraf The merge that happened the other day merged into a branch instead of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551