Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cell deletion suggestions #15

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Support cell deletion suggestions #15

merged 2 commits into from
Dec 19, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Dec 17, 2024 •
edited
Loading

User-facing changes

  • The cell suggestion button is now a drop-down menu
  • Add Suggest change and Suggest delete option
delete.mp4

@trungleduc trungleduc added the enhancement New feature or request label Dec 17, 2024
@trungleduc
Copy link
Member Author

This PR is built on top of #13

@trungleduc trungleduc marked this pull request as ready for review December 18, 2024 16:06
@trungleduc trungleduc requested a review from jtpio December 18, 2024 22:08
@trungleduc
Copy link
Member Author

Rebased after #13

jtpio
jtpio reviewed Dec 19, 2024
View reviewed changes
packages/base/src/types.ts Outdated Show resolved Hide resolved
@trungleduc @jtpio
Update packages/base/src/types.ts
f409c47 
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
jtpio
jtpio approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@trungleduc trungleduc merged commit fdd757e into jupyterlab-contrib:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @jtpio