Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI tests #17

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Add UI tests #17

merged 4 commits into from
Dec 19, 2024

Conversation

trungleduc
Copy link
Member

No description provided.

@trungleduc trungleduc force-pushed the ui-test branch 2 times, most recently from 8400243 to 4da7554 Compare December 19, 2024 13:13
@trungleduc trungleduc marked this pull request as ready for review December 19, 2024 16:04
@trungleduc trungleduc requested a review from jtpio December 19, 2024 16:04
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

run: |
set -eux
cp ./jupyter_suggestions_core/dist/jupyter_suggestions_core*.whl .
pip install "jupyterlab>=4.0.0,<5" jupyter_suggestions_core*.whl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping we won't be catching too many styling changes from JupyterLab in the next 4.x updates. Otherwise we could narrow the range down a bit.

@trungleduc trungleduc merged commit b6f3e99 into jupyterlab-contrib:main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterLite demo: menu does not open
2 participants