Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save suggestions to notebook metadata #8

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Save suggestions to notebook metadata #8

merged 5 commits into from
Dec 3, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Nov 28, 2024 •
edited
Loading

Code changes

  • Add a toolbar to each suggestion widget containing Collapse/Expand, Accept and Delete buttons
  • Save suggestions to notebook metadata
suggestion3.mp4

@trungleduc trungleduc added the enhancement New feature or request label Nov 28, 2024
@jtpio jtpio linked an issue Dec 2, 2024 that may be closed by this pull request
Store comments in the notebook metadata #1
Closed
@trungleduc trungleduc mentioned this pull request Dec 2, 2024
Merged
@trungleduc trungleduc marked this pull request as ready for review December 2, 2024 12:10
@trungleduc trungleduc requested a review from jtpio December 2, 2024 12:10
jtpio
jtpio approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, thanks for this!

@jtpio jtpio merged commit 26b0012 into jupyterlab-contrib:main Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store comments in the notebook metadata
2 participants
@trungleduc @jtpio