Skip to content

Commit

Permalink
Initialise _showWidget in FavoritesManager (#11)
Browse files Browse the repository at this point in the history
* Ensure _showWidget is initialised in the FavoritesManager

Sometimes if this is not initialised it could flow down
to the React widget and cause the widget to fail to Render.

* Update GH workflows

Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
  • Loading branch information
mctoohey and fcollonval authored Jan 3, 2023
1 parent ad56901 commit 958fe21
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 22 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/binder-on-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: comment on PR with Binder link
uses: actions/github-script@v3
uses: actions/github-script@v6
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
var PR_HEAD_USERREPO = process.env.PR_HEAD_USERREPO;
var PR_HEAD_REF = process.env.PR_HEAD_REF;
github.issues.createComment({
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down
27 changes: 12 additions & 15 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,23 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Install node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: '12.x'
node-version: '16'
- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: '3.7'
architecture: 'x64'

python-version: '3.10'

- name: Setup pip cache
uses: actions/cache@v2
with:
path: ~/.cache/pip
key: pip-3.7-${{ hashFiles('package.json') }}
key: pip-3.10-${{ hashFiles('package.json') }}
restore-keys: |
pip-3.7-
pip-3.10-
pip-
- name: Get yarn cache directory path
Expand Down Expand Up @@ -66,7 +64,7 @@ jobs:
pip uninstall -y myextension jupyterlab
rm -rf myextension
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
with:
name: myextension-sdist
path: myextension.tar.gz
Expand All @@ -77,13 +75,12 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: '3.8'
architecture: 'x64'
- uses: actions/download-artifact@v2
python-version: '3.10'
- uses: actions/download-artifact@v3
with:
name: myextension-sdist
- name: Install and Test
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,13 @@ jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: '14.x'
registry-url: 'https://registry.npmjs.org'
node-version: '16'
- name: Install Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: '3.x'
- name: Install dependencies
Expand Down
1 change: 1 addition & 0 deletions src/manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export class FavoritesManager {
settings: ISettingRegistry,
contents: ContentsManager
) {
this._showWidget = true;
this._serverRoot = serverRoot;
this._commandRegistry = commands;
this._settingsRegistry = settings;
Expand Down

0 comments on commit 958fe21

Please sign in to comment.