Skip to content

Commit

Permalink
Fix and lint
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Nov 3, 2023
1 parent 8d82821 commit 18eb753
Show file tree
Hide file tree
Showing 3 changed files with 142 additions and 490 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prettier:check": "jlpm prettier:base --check",
"stylelint": "jlpm stylelint:check --fix",
"stylelint:check": "stylelint --cache \"style/**/*.css\"",
"watch": "run-p watch:src watch:labextension",
"watch": "run-p watch:src watch:labextension",
"watch:labextension": "jupyter labextension watch .",
"watch:src": "tsc -w --sourceMap"
},
Expand All @@ -58,7 +58,7 @@
"@jupyterlab/coreutils": "^6.0.0",
"@jupyterlab/notebook": "^4.0.0",
"@jupyterlab/outputarea": "^4.0.0",
"@jupyterlab/rendermime": "^3.8.0",
"@jupyterlab/rendermime": "^4.0.0",
"@jupyterlab/services": "^7.0.0",
"@jupyterlab/ui-components": "^4.0.0",
"@lumino/coreutils": "^2.0.0",
Expand All @@ -70,7 +70,7 @@
},
"devDependencies": {
"@jupyterlab/builder": "^4.0.0",
"@types/json-schema": "^7.0.11",
"@types/json-schema": "^7.0.11",
"@types/react": "^18.0.26",
"@types/react-addons-linked-state-mixin": "^0.14.22",
"@typescript-eslint/eslint-plugin": "^6.1.0",
Expand All @@ -79,7 +79,7 @@
"eslint": "^8.36.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-prettier": "^5.0.0",
"npm-run-all": "^4.1.5",
"npm-run-all": "^4.1.5",
"prettier": "^3.0.0",
"rimraf": "^5.0.1",
"source-map-loader": "^1.0.2",
Expand Down
7 changes: 3 additions & 4 deletions ui-tests/tests/lckr_jupyterlab_variableinspector.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { expect, test } from '@jupyterlab/galata';


test('test', async ({ page }) => {
await page.getByText('Python 3 (ipykernel)').first().click();
await page.getByText('Python 3 (ipykernel) | Idle').waitFor();
Expand All @@ -14,6 +13,6 @@ test('test', async ({ page }) => {
});
await page.getByRole('menu').getByText('Open Variable Inspector').click();

await expect(page.getByRole('row').nth(1)).toHaveText(/aint281$/)
await expect(page.getByRole('row').last()).toHaveText(/bstr46hello$/)
});
await expect(page.getByRole('row').nth(1)).toHaveText(/aint281$/);
await expect(page.getByRole('row').last()).toHaveText(/bstr46hello$/);

Check failure on line 17 in ui-tests/tests/lckr_jupyterlab_variableinspector.spec.ts

View workflow job for this annotation

GitHub Actions / Integration tests

tests/lckr_jupyterlab_variableinspector.spec.ts:3:5 › test

1) tests/lckr_jupyterlab_variableinspector.spec.ts:3:5 › test ──────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: getByRole('row').last() Expected pattern: /bstr46hello$/ Received string: "bstr54hello" Call log: - expect.toHaveText with timeout 5000ms - waiting for getByRole('row').last() - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" - locator resolved to <tr>…</tr> - unexpected value "bstr54hello" 15 | 16 | await expect(page.getByRole('row').nth(1)).toHaveText(/aint281$/); > 17 | await expect(page.getByRole('row').last()).toHaveText(/bstr46hello$/); | ^ 18 | }); 19 | at /home/runner/work/jupyterlab-variableInspector/jupyterlab-variableInspector/ui-tests/tests/lckr_jupyterlab_variableinspector.spec.ts:17:46
});
Loading

0 comments on commit 18eb753

Please sign in to comment.