Lazy inspection #309
Merged
Lazy inspection #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trungleduc
approved these changes
Aug 29, 2024
krassowski
reviewed
Aug 29, 2024
|
The visual regression tests seem to fail on main too, this #310 should fix it |
krassowski
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Thank you @martinRenou - let's merge main/rebase to make sure if CI passes
Do not request anything from the kernel if the variable inspector is not currently open
martinRenou
force-pushed
the
disable_inspection_when_ui_not_open
branch
from
aeaf5c5
to
be01506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not request anything from the kernel if the variable inspector is not currently open
This fixes performances issues, at least when the UI for the variable inspector is not open #307
cc. @achhina @trungleduc