Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to create a slideshow in the README #100

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

kir0ul
Copy link
Contributor

@kir0ul kir0ul commented Oct 2, 2024

Fix issues #73 and #45.

Copy link

github-actions bot commented Oct 2, 2024

Binder 👈 Launch a Binder on branch kir0ul/rise/patch-1

@kir0ul kir0ul changed the title Document how to make a slideshow in the README Document how to create a slideshow in the README Oct 2, 2024
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kir0ul but could you please rather add the images within the repository instead of linking external images (especially as they involved authentication and token...).

@kir0ul
Copy link
Contributor Author

kir0ul commented Dec 9, 2024

Thanks @kir0ul but could you please rather add the images within the repository instead of linking external images (especially as they involved authentication and token...).

Sure, I just didn't know where to put them. What's the best place where those images could go?

@fcollonval
Copy link
Member

@kir0ul could you create a docs folder in the repo to store them?

@kir0ul
Copy link
Contributor Author

kir0ul commented Dec 28, 2024

@kir0ul could you create a docs folder in the repo to store them?

@fcollonval Done ✔️

@fcollonval
Copy link
Member

Thanks @kir0ul

@fcollonval fcollonval merged commit 3518b57 into jupyterlab-contrib:main Dec 30, 2024
@fcollonval fcollonval added the documentation Improvements or additions to documentation label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants