Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes running cells and jump to active cell #38

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fixes running cells and jump to active cell #38

merged 2 commits into from
Jul 24, 2023

Conversation

hbcarlos
Copy link
Contributor

Fixes #12

@github-actions
Copy link

Binder 👈 Launch a Binder on branch hbcarlos/rise/fix_12

@fcollonval fcollonval added the bug Something isn't working label Jul 21, 2023
fcollonval
fcollonval reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

I have a minor comment. But not directly related to your code.

packages/application/src/plugins/rise.ts Outdated Show resolved Hide resolved
fcollonval
fcollonval approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit ce1e1f0 into jupyterlab-contrib:main Jul 24, 2023
@hbcarlos hbcarlos deleted the fix_12 branch September 4, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shift-enter in command mode does not execute cells
2 participants
@hbcarlos @fcollonval