Wait for notebook to be ready before converting to presentation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fcollonval
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Thanks a lot @AnotherCodeArtist for fixing the bug and improving the configuration.
fcollonval
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR fixes #8. The problem was, that the
dirtyflag is apparently no indicator for a complete model/context. Thus, although this flag got changed tofalse, some code blocks have not been present, causing the reported issue. I changed this for thenotebookPanel.context.readypromise, which makes the code leaner and of course reliable. Now all code cells are fully loaded wheninitializeRevealgets called.Besides this I configured TS to produce source maps, in order to facilitate debugging. Since
'extra-watch-webpack-plugin'caused nothing but troubles for me, I dared to remove it.