Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from Playwright docs link #29

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

chrispyles
Copy link
Contributor

The URL https://playwright.dev/docs/intro/ returns a 404 which causes the link check to fail (example), the correct URL is https://playwright.dev/docs/intro.

Screenshot 2023-07-09 at 9 59 53 AM

@welcome
Copy link

welcome bot commented Jul 9, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrispyles

@fcollonval fcollonval merged commit 8657ac2 into jupyterlab:main Jul 11, 2023
23 checks passed
@welcome
Copy link

welcome bot commented Jul 11, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval added the documentation Improvements or additions to documentation label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants