Remove pip install -e . step from the check release workflow
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
commented
Aug 2, 2023
| @@ -72,6 +72,7 @@ | |||
| "@types/jest": "^29.2.0",{% endif %} | |||
| "@types/json-schema": "^7.0.11", | |||
| "@types/react": "^18.0.26", | |||
| "@types/react-addons-linked-state-mixin": "^0.14.22", | |||
There was a problem hiding this comment.
Maybe the template should ship a yarn.lock by default? Looking at the repo it does not seem to have one.
There was a problem hiding this comment.
Although that could be tricky since some dependencies depend on the answers provided when bootstrapping the extension.
|
Merging as this should also already help fix issues like jupyterlab/jupyterlab#14898 |
|
What is |
|
I opened #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step should not be necessary and might add side-effects. Also it does not exist during the actual release process.
Noticed in jupyterlab/jupyterlab-github#145 (comment)