Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui-tests #44

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix ui-tests #44

merged 2 commits into from
Sep 18, 2023

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Sep 18, 2023

The current project structure includes ui-tests as a workspace of the project.
In the same time there is an empty yarn.lock file it the ui-test directory, meaning (for yarn) that it should be treated as a completely separated project.

This PR assumes that we should treat the ui-tests as a separated project, and remove it from the project workspaces. It also allows to modify its yarn.lock file during CI.

If we aim to treat the ui-tests as a workspace (instead of a separated project), we should probably fix the check_release test which fails with workspaces (e.g. https://github.com/QuantStack/jupyter-sql-cell/actions/runs/6198336848/job/16828578630)

@welcome
Copy link

welcome bot commented Sep 18, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval
Copy link
Member

FYI the releaser test will be fixed by jupyter-server/jupyter_releaser#522

@fcollonval fcollonval added the enhancement New feature or request label Sep 18, 2023
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brichet

@fcollonval fcollonval merged commit d3fde34 into jupyterlab:main Sep 18, 2023
23 checks passed
@welcome
Copy link

welcome bot commented Sep 18, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval added bug Something isn't working and removed enhancement New feature or request labels Sep 18, 2023
@brichet brichet deleted the fixup branch September 18, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants